iwa: Add --internal-routing flag for app creation

heroku / heroku-apps

Heroku Core CLI Plugin for managing Heroku apps

https://cli.heroku.com

ISC License

19 stars 26 forks source link

iwa: Add --internal-routing flag for app creation #235

Closed watsonian closed 6 years ago

watsonian commented 6 years ago

This adds the requisite flag for an upcoming feature. The API changes for this have yet to be implemented and this may change a bit depending on https://github.com/heroku/dogwood/issues/1743. Just getting this up for general review and so we have something to reference for the changeset.

jdx commented 6 years ago

please don't merge this because this repo has special commit rules to get it into the CHANGELOG. Just let me know when you're ready and I'll merge it.

watsonian commented 6 years ago

Sounds good. I think we're going to be waiting on some API changes before merging this anyways.

watsonian commented 6 years ago

@jdxcode Okay, this should be ready to merge. The API changes we need from https://github.com/heroku/api/pull/9516 are merged and deployed. I missed something that's getting fixed in https://github.com/heroku/api/pull/9546, but the field is there so references to it will work properly.

heroku-cli commented 6 years ago

:tada: This PR is included in version 2.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: