search

heroku / heroku-buildpack-clojure

Heroku's buildpack for Clojure applications.
MIT License
117 stars 114 forks source link

Feature: Support for deps.edn-only projects #112

Closed cap10morgan closed 9 months ago

cap10morgan commented 2 years ago

Closes #75

This detects when projects only have a deps.edn file and uses the Clojure CLI tools to build and run the app instead of lein. I have tested it with one of my deps.edn apps and it is working there.

cap10morgan commented 2 years ago

Should I point the tests at this fork for now? They pass when I do that locally.

cap10morgan commented 2 years ago

@heroku/languages any chance this can get reviewed if I rebase on main?

cap10morgan commented 2 years ago

@edmorley @schneems @lillianzhang331 Sorry for pinging you randomly but I saw that you reviewed and merged a few recent PRs. Any chance of getting this one reviewed if I rebase on latest main?

Malax commented 2 years ago

Hey @cap10morgan! Sorry for the long delay on this, my apologies! This is a IMO great addition to the buildpack, thanks for working on this!

I won't have time to review this immediately, but I should have some time next week. Feel free to ping me directly in the future so we can get this over the finish line! :)

cap10morgan commented 2 years ago

Thanks @Malax! I'll get this mergeable with main again then.

cap10morgan commented 2 years ago

@Malax Ready for review whenever you get a moment (and thanks again!)

Malax commented 2 years ago

@cap10morgan I've just pulled your branch into this repo so that CI can run (we disable CI for external PR's to avoid leaking credentials). As you can see, it went through without a hitch. I'll continue with a code review as the next step! :)

cap10morgan commented 2 years ago

@Malax any updates on this? Let me know if there is anything else I can do to move this forward on my end. Thanks!

skydread1 commented 2 years ago

Hi, any updates on this? I will really like to see this feature available as we use deps.edn only as well.

versality commented 9 months ago

+1 We're also building a deps.edn only project and considering to use Heroku. Would be great to have it merged.

cap10morgan commented 9 months ago

I no longer use Heroku and wouldn't even be willing to resolve the conflicts in here at this point. I recommend seeking out hosting platforms that give a shit instead.