search

heroku / heroku-buildpack-clojure

Heroku's buildpack for Clojure applications.
MIT License
117 stars 114 forks source link

Switch to the recommended regional S3 domain #119

Closed edmorley closed 2 years ago

edmorley commented 2 years ago

Whilst the global S3 endpoint (s3.amazonaws.com) still works, AWS now recommends using the appropriate regional endpoint to access the bucket: https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#s3-legacy-endpoints

Our buildpack buckets are in us-east-1, whose regional domain is *.s3.us-east-1.amazonaws.com: https://docs.aws.amazon.com/general/latest/gr/s3.html#s3_region

GUS-W-11283397.

edmorley commented 2 years ago

I had to add a commit to fix tests failing on main, due to the JVM common log output change.