search

heroku / heroku-buildpack-clojure

Heroku's buildpack for Clojure applications.
MIT License
117 stars 114 forks source link

Dont suppress errors during Clojure download #146

Closed Malax closed 1 year ago

Malax commented 1 year ago

Currently, when the download of the Clojure CLI fails the actual error is not surfaced. This makes debugging much harder, especially when intermittent network errors are the cause. This PR adds -S to the curl command, surfacing errors to the build log.

Before:

remote:        Need to get 0 B/98.2 kB of archives.
remote:        After this operation, 309 kB of additional disk space will be used.
remote:        Download complete and in download only mode
remote: -----> Installing Clojure foobar CLI tools
remote:  !     Push rejected, failed to compile Clojure (Leiningen 2) app.
remote:
remote:  !     Push failed

After:

remote:        Need to get 0 B/98.2 kB of archives.
remote:        After this operation, 309 kB of additional disk space will be used.
remote:        Download complete and in download only mode
remote: -----> Installing Clojure foobar CLI tools
remote: curl: (22) The requested URL returned error: 403
remote:  !     Push rejected, failed to compile Clojure (Leiningen 2) app.
remote:
remote:  !     Push failed

Closes: GUS-W-13879339