employ existing bower_components

heroku / heroku-buildpack-ember-cli

A Heroku buildpack for ember-cli apps; powers dashboard.heroku.com

58 stars 15 forks source link

employ existing bower_components #17

Closed jmonster closed 7 years ago

jmonster commented 7 years ago

tl;dr this should speed up builds of ember-cli applications that use yarn or cache bower_components

Installing bower dependencies in the buildpack rather than with the postinstall hook of of your package.json renders the nodejs buildpack's caching of bower_components inert. This fixes that.

jmonster commented 7 years ago

@joshwlewis please review :)

jmonster commented 7 years ago

Updated based on feedback and made adjustments to ensure the following scenarios succeed (I used burnward):

[x] succeeds with bower_components committed to the repo
[x] succeeds with a valid bower.json
[x] project does not have bower as a dependency
[x] project has bower as a dependency
[x] build fails when bower install fails (e.g. unauthorized access to purple)

caseywatts commented 7 years ago

👏