heroku / heroku-buildpack-ember-cli

A Heroku buildpack for ember-cli apps; powers dashboard.heroku.com
58 stars 15 forks source link

Make Bower Optional #21

Closed caseywatts closed 6 years ago

caseywatts commented 6 years ago

Currently I have to have this bower.json in my app in order to deploy to Heroku:

{
  "name": "partner-portal-ui",
  "dependencies": {
  }
}

Ember doesn't require bower anymore - our buildpack doesn't need to, either :) (nice summary in this comment: https://github.com/jherdman/ember-cli-chartist/issues/61)

I suggest we only do the bower steps if a bower.json is detected. Does that sound right?