heroku / heroku-buildpack-go

Heroku Go Buildpack
https://devcenter.heroku.com/categories/go
MIT License
792 stars 511 forks source link

Should recognize valid code.google.com certificate #27

Closed msakrejda closed 9 years ago

msakrejda commented 11 years ago

As part of building, I see the following:

-----> Running: godep go get -tags heroku ./...
warning: code.google.com certificate with fingerprint 76:9a:5d:41:30:bd:48:c6:93:56:16:1d:e7:c3:89:ff:62:60:ca:f3 not verified (check hostfingerprints or web.cacerts config setting)
-----> Discovering process types

This does not happen locally, so presumably the cert is legit:

maciek@gamera:~/code/aux/go/src/code.google.com/p/go.crypto$ hg pull
pulling from https://code.google.com/p/go.crypto
searching for changes
adding changesets
adding manifests
adding file changes
added 16 changesets with 50 changes to 30 files
(run 'hg update' to get a working copy)
maciek@gamera:~/code/aux/go/src/code.google.com/p/go.crypto$
kr commented 11 years ago

Note to self: put the following in $HOME/.hgrc:

[web]
cacerts = /etc/ssl/certs/ca-certificates.crt

See also http://golang.org/doc/install/source and http://mercurial.selenic.com/wiki/CACertificates#Configuration_of_HTTPS_certificate_authorities.

kr commented 11 years ago

Heh:

Mercurial has improved its HTTPS support in the 1.7.x series. … The new "certificate not verified" warning does not mean that you are less secure than before. It just informs you of how insecure you have always been.

kristofer commented 10 years ago

this seems to be back as of this date? when I just now tried to push an app...

$  heroku config:set BUILDPACK_URL=https://github.com/kr/heroku-buildpack-go.git#master
Setting config vars and restarting telltaleky... done, v45
BUILDPACK_URL: https://github.com/kr/heroku-buildpack-go.git#master
Aeneid:telltale kyounger$ git push heroku master
Fetching repository, done.
Counting objects: 5, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 344 bytes | 0 bytes/s, done.
Total 3 (delta 2), reused 0 (delta 0)

-----> Fetching custom git buildpack... done
-----> Go app detected
-----> Using go1.2.1
-----> Running: go get -tags heroku ./...
found packages telltale (forecastie.go) and main (nwssoap.go) in Support
# cd .; hg clone -U https://code.google.com/p/go-charset /tmp/build_967f933f-7780-4307-a342-788706d9dff7/.heroku/g/src/code.google.com/p/go-charset
Traceback (most recent call last):
  File "/app/tmp/cache/venv/bin/hg", line 36, in <module>
    mercurial.util.setbinary(fp)
  File "/app/tmp/cache/venv/lib/python2.7/site-packages/mercurial/demandimport.py", line 102, in __getattribute__
    self._load()
  File "/app/tmp/cache/venv/lib/python2.7/site-packages/mercurial/demandimport.py", line 74, in _load
    mod = _hgextimport(_import, head, globals, locals, None, level)
  File "/app/tmp/cache/venv/lib/python2.7/site-packages/mercurial/demandimport.py", line 43, in _hgextimport
    return importfunc(name, globals, *args)
  File "/app/tmp/cache/venv/lib/python2.7/site-packages/mercurial/util.py", line 16, in <module>
    from i18n import _
  File "/app/tmp/cache/venv/lib/python2.7/site-packages/mercurial/demandimport.py", line 130, in _demandimport
    mod = _hgextimport(_origimport, name, globals, locals)
  File "/app/tmp/cache/venv/lib/python2.7/site-packages/mercurial/demandimport.py", line 43, in _hgextimport
    return importfunc(name, globals, *args)
  File "/app/tmp/cache/venv/lib/python2.7/site-packages/mercurial/i18n.py", line 23, in <module>
    t = gettext.translation('hg', localedir, fallback=True)
  File "/usr/local/lib/python2.7/gettext.py", line 465, in translation
    mofiles = find(domain, localedir, languages, all=1)
  File "/usr/local/lib/python2.7/gettext.py", line 437, in find
    for nelang in _expand_lang(lang):
  File "/usr/local/lib/python2.7/gettext.py", line 131, in _expand_lang
    from locale import normalize
  File "/app/tmp/cache/venv/lib/python2.7/site-packages/mercurial/demandimport.py", line 111, in _demandimport
    return _hgextimport(_import, name, globals, locals, fromlist, level)
  File "/app/tmp/cache/venv/lib/python2.7/site-packages/mercurial/demandimport.py", line 43, in _hgextimport
    return importfunc(name, globals, *args)
  File "/app/tmp/cache/venv/lib/python2.7/locale.py", line 182, in <module>
    _percent_re = re.compile(r'%(?:\((?P<key>.*?)\))?'
  File "/app/tmp/cache/venv/lib/python2.7/site-packages/mercurial/demandimport.py", line 102, in __getattribute__
    self._load()
  File "/app/tmp/cache/venv/lib/python2.7/site-packages/mercurial/demandimport.py", line 74, in _load
    mod = _hgextimport(_import, head, globals, locals, None, level)
  File "/app/tmp/cache/venv/lib/python2.7/site-packages/mercurial/demandimport.py", line 43, in _hgextimport
    return importfunc(name, globals, *args)
  File "/app/tmp/cache/venv/lib/python2.7/re.py", line 222, in <module>
    _pattern_type = type(sre_compile.compile("", 0))
  File "/app/tmp/cache/venv/lib/python2.7/sre_compile.py", line 502, in compile
    code = _code(p, flags)
  File "/app/tmp/cache/venv/lib/python2.7/sre_compile.py", line 484, in _code
    _compile_info(code, p, flags)
  File "/app/tmp/cache/venv/lib/python2.7/sre_compile.py", line 363, in _compile_info
    lo, hi = pattern.getwidth()
  File "/app/tmp/cache/venv/lib/python2.7/sre_parse.py", line 174, in getwidth
    self.width = min(lo, MAXREPEAT - 1), min(hi, MAXREPEAT)
TypeError: unsupported operand type(s) for -: '_demandmod' and 'int'
package code.google.com/p/go-charset/charset: exit status 1
package code.google.com/p/go-charset/data
    imports code.google.com/p/go-charset/data
    imports code.google.com/p/go-charset/data: cannot find package "code.google.com/p/go-charset/data" in any of:
    /app/tmp/cache/go1.2.1/go/src/pkg/code.google.com/p/go-charset/data (from $GOROOT)
    /tmp/build_967f933f-7780-4307-a342-788706d9dff7/.heroku/g/src/code.google.com/p/go-charset/data (from $GOPATH)

 !     Push rejected, failed to compile Go app

To git@heroku.com:telltaleky.git
 ! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'git@heroku.com:telltaleky.git'

when I did it locally, I got

$ hg clone -U https://code.google.com/p/go-charset
warning: code.google.com certificate with fingerprint 58:e9:65:a5:35:b0:20:4c:eb:15:1e:3f:ea:71:fb:f2:4c:5b:a2:c7 not verified (check hostfingerprints or web.cacerts config setting)
destination directory: go-charset
requesting all changes
adding changesets
adding manifests
adding file changes
added 32 changesets with 198 changes to 135 files

so I am confused.

notnil commented 10 years ago

same issue here with https://code.google.com/p/go.crypto/bcrypt

freeformz commented 9 years ago

Closing as godep does vendoring by default now, so you should not see this anymore.