heroku / heroku-buildpack-google-chrome

Run (headless) Google Chrome on Heroku
296 stars 365 forks source link

update packages required to be installed #103

Closed fivetanley closed 3 years ago

fivetanley commented 3 years ago

copied from https://developers.google.com/web/tools/puppeteer/troubleshooting

Chrome 88 also seems to have introduced a dependencyon libxhsmfence as well.

mweitzel commented 3 years ago

Instead of pulling "common dependencies" from the puppeteer page, can we provide a more consistent and robust way of creating this dependency list ourselves?

The comment indicates you can determine the dependencies via ldd $GOOGLE_CHROME_BIN | grep not. Should we pull from that instead of a list from puppeteer page?

When I pull https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb and unpack it, the control/control file specifies dependencies. These dependencies differ from yours as follows. (by running diff this-pr pkg-deb-control-deps)

3d2
< libappindicator3-1
6a6
> libatspi2.0-0
10a11
> libdrm2
12d12
< libfontconfig1
14a15
> libgdk-pixbuf2.0-0
20,21d20
< libpangocairo-1.0-0
< libstdc++6
23d21
< libx11-xcb1
26d23
< libxcursor1
30c27
< libxi6
---
> libxkbcommon0
32,36c29
< libxrender1
< libxss1
< libxhsmfence
< libxtst6
< lsb-release
---
> libxshmfence1
fivetanley commented 3 years ago

closed in favor of #104