search

heroku / heroku-buildpack-google-chrome

Run (headless) Google Chrome on Heroku
296 stars 365 forks source link

Print installed version number #78

Closed eliotsykes closed 4 years ago

eliotsykes commented 5 years ago

Useful when debugging issues related to installed version of Google Chrome, e.g. version mismatch with chromedriver.

simonv3 commented 5 years ago

I would love this PR to get merged.

jipiboily commented 5 years ago

Would love to see this in, too! Anything we can do to help get that in?

eliotsykes commented 5 years ago

@joshwlewis is there anything I need to do to pass the pending heroku/compliance check?

jeremiemv commented 4 years ago

@joshwlewis I'd like to upvote this PR. Thanks!

fkztw commented 4 years ago

@eliotsykes Have you tried this patch in the building process of your Heroku app? I am asking this question because I was working on a related problem these days and found out this PR. I don't think this patch would work. I think it will get the error message like this: /tmp/build_04cb8278/.apt/usr/bin/google-chrome: line 3: /app/.apt/opt/google/chrome/chrome: No such file or directory

Here's the reason: $BIN_DIR/google-chrome is an alias and it's content is https://github.com/heroku/heroku-buildpack-google-chrome/blob/e85ed96d67c05d35fd1488948c16603b4e4b8717/bin/compile#L172-L186

The problem is things are not been moved/copied to $HOME during building process. Should use $BUILD_DIR/.apt/opt/google/$BIN --product-version or $BUILD_DIR/.apt/opt/google/$BIN --version

eliotsykes commented 4 years ago

Have you try this patch in the building process of your Heroku app?

@M157q I don't remember, probably not by the sounds of your investigations.

My guess is I threw this together quickly as a speculative PR with the intention of spending more time on it had the buildpack's maintainers shown interest in the idea.

So I'll close this for lack of interest. Maintainers feel free to re-open.