Require gradle wrapper and use `gradlew` script as detection hueristic

heroku / heroku-buildpack-gradle

Heroku's buildpack for Gradle applications.

MIT License

63 stars 91 forks source link

Require gradle wrapper and use `gradlew` script as detection hueristic #17

Closed ldaley closed 7 years ago

ldaley commented 10 years ago

Hi,

I think it would be better for everyone if the buildpack required the Gradle wrapper. All projects should use the wrapper and relying on the version provided by Heroku is fragile at best.

I'm happy to supply the PR if it's agreed that this is the way to go.

davidmc24 commented 10 years ago

I agree with this suggestion.

Zenedith commented 10 years ago

:+1:

fge commented 10 years ago

Definitely agreed. All that the wrapper needs is a JDK installed. And it leaves the freedom for users to use the version they want and not forcefeed them a version they don't want to use.