search

heroku / heroku-buildpack-nginx

Run NGINX in a Heroku app
244 stars 787 forks source link

Fix PATH to vendored Ruby #108

Open r4victor opened 2 years ago

r4victor commented 2 years ago

Fixes #107

r4victor commented 2 years ago

I wasn't aware of buildpacks modifying $HOME. But this is not a problem – we can use it instead of hardcoded /app. Will it do?

heroku-buildpack-subdir can't fix this by modifying $HOME since there can be multiple buildpacks but only one $HOME.

The reason why I think the fix belongs here is because of the inconsistency: compile puts the ruby executable in the location controlled by $BUILD_DIR but ignores it when setting $PATH.

Other buildpacks that I'm aware of that modify $PATH work with heroku-buildpack-subdir because they install to /app/.heroku/ and symlink the $BUILD_DIR-based path. For example, see Python buildpack, PHP buildpack. Since nginx buildpack already installs to $BUILD_DIR-based path, I think the best approach here is to set $PATH accordingly.