search

heroku / heroku-buildpack-nginx

Run NGINX in a Heroku app
245 stars 786 forks source link

Add NGINX_WORKER_CONNECTIONS env var to set worker_connections #30

Closed bits01 closed 5 years ago

bits01 commented 5 years ago

Useful to increase the number of connections per worker without adding more processes or using a custom conf file.

beanieboi commented 5 years ago

Would you mind adding something to the README that this ENV var exists, to make it easier for users to discover the possibility to change it

bits01 commented 5 years ago

Good point, I will do so.

bits01 commented 5 years ago

If this PR is accepted, how soon can it become available for use on Heroku production?

beanieboi commented 5 years ago

This depends on how you configured the buildpack. if you point your app to a specific commit, you need to update that. otherwise it will pick up master right away on your next deploy.

see: https://devcenter.heroku.com/articles/buildpacks#using-a-third-party-buildpack

bits01 commented 5 years ago

Thank you for the quick turnaround.