search

heroku / heroku-buildpack-nginx

Run NGINX in a Heroku app
244 stars 787 forks source link

Patch nginx so it does graceful shutdown on SIGTERM and fast shutdown… #88

Open syastrov opened 3 years ago

syastrov commented 3 years ago

… on SIGQUIT.

Fixes https://github.com/heroku/heroku-buildpack-nginx/issues/31

I tested manually that this works.

Based on https://github.com/heroku/heroku-buildpack-nginx/pull/56

syastrov commented 2 years ago

@beanieboi Any chance of merging this?

nenadfspartans commented 2 years ago

@beanieboi Any update on this?

jaGarcia commented 1 year ago

Running into nginx seemingly not passing the SIGTERM call to the underlying spring/java process. Any way to get this PR merged?

tkrevh commented 2 weeks ago

Could someone please merge this? We're using this patch (from a forked repo) on our Heroku production system for a couple of years now with great success. Unfortunately, the forked repo only supports stack up to heroku-20.

So merge of this branch would be great. Thank you! :)

nenadfilipovic commented 2 weeks ago

Could someone please merge this? We're using this patch (from a forked repo) on our Heroku production system for a couple of years now with great success. Unfortunately, the forked repo only supports stack up to heroku-20.

So merge of this branch would be great. Thank you! :)

Hi, I am using my fork for about two years now https://github.com/nenadfilipovic/heroku-buildpack-nginx, works without issues. You can add it via https://buildpack-registry.s3.amazonaws.com/buildpacks/nenadfilipovic/heroku-buildpack-nginx.tgz inside buildpacks list or by nenadfilipovic/heroku-buildpack-nginx.