heroku / heroku-buildpack-php

Heroku's buildpack for PHP applications.
https://devcenter.heroku.com/categories/php
MIT License
808 stars 1 forks source link

Amqp extension support #107

Closed stof closed 5 years ago

stof commented 9 years ago

it would be great to support the amqp extension, to allow easier usage of RabbitMQ on heroku (the userland implementation is not good. It is leaking and does not implement prefetching properly)

dzuelke commented 9 years ago

Agreed; it's on my list, just haven't tackled it yet because of the libamqp dep. Soon!

stof commented 8 years ago

@dzuelke now that deps are resolved with composer too, could deps like libamqp be installed the same way, by creating heroku-sys/libamqp and making it a dependency of each heroku-sys/ext-amqp package ?

dzuelke commented 8 years ago

Potentially, although I'm not sure what the benefit would be; you could ship libamqp bundled with ext-amqp instead (like the buildpack does with e.g. the memcached extension).

I am currently negotiating with those responsible for the cedar stack images to include libamqp ;) I'd really rather not maintain all those PECL extensions with their different libraries by hand, it's just a massive burden (and occasionally a security consideration too).

Wouldn't you be interested in running an S3 bucket with a few unofficial extensions @stof? ;)

stof commented 8 years ago

@dzuelke I am, which is why I'm looking into this. See #157

stof commented 8 years ago

I am currently negotiating with those responsible for the cedar stack images to include libamqp ;)

That would be awesome (in which case ext-amqp could maybe even become part of the extensions supported in the core)

dzuelke commented 8 years ago

Yeah once libamqp would be in cedar for sure I'd maintain it officially.

stof commented 8 years ago

note that compiling recent versions of ext-amqp depends on an uptodate version of librabbitmp, not on the old version available in Ubuntu 14.04

dzuelke commented 8 years ago

Eww.

stof commented 8 years ago

see https://github.com/pdezwart/php-amqp#requirements

Ubuntu 14.04 ships with librabbitmq 0.4.1 released in August 2013.

And older versions of ext-amqp supporting this very old versions are not compatible with PHP 7 (support is added in 1.7.0-alpha) and suffer from bugs (impacting the connection to RabbitMQ provided by the CloudAMQP addon btw)

stof commented 8 years ago

@dzuelke do you have any news from the cedar stack team regarding this ?

dzuelke commented 8 years ago

Oh sorry I thought you had given the answer yourself after pointing out that the version that ships with 14.04 is too old anyway :/

stof commented 8 years ago

well, have you asked them though ? not all cedar packages are using the version available in Ubuntu 14.04 (Ubuntu 14.04 contains postgresql-client-9.3, not postgresql-client-9.5 for instance, but I haven't checked the full list to compare it with ubuntu versions to build an exhaustive list)

dzuelke commented 8 years ago

Yeah, not happening for now, at least not for cedar-14 (maybe Ubuntu 16.04 will bring a more suitable version, and we'll then revisit what packages to include in the stack image(s)).

Postgres is the sole exception since we offer that as a service, and older clients cannot access newer servers. But that's also not maintained by hand, but from an upstream Ubuntu repo.

stof commented 8 years ago

Closing because the support is provided in https://github.com/Incenteev/heroku-php-exts now

dzuelke commented 7 years ago

Reopening to track adoption for new heroku-16 stack.

stof commented 7 years ago

Well, wouldn't it be better to open an issue on my repo instead ?

stof commented 7 years ago

I opened https://github.com/Incenteev/heroku-php-exts/pull/2 about the progress on the heroku-16 stack support. I will merge it once the building is working

dzuelke commented 7 years ago

Sorry, misleading phrasing. I'd like to provide that ext out of the box on Heroku for the new stack now that Ubuntu has a suitable library version of librabbitmq.

stof commented 5 years ago

Closing this, as it is now supported in the buildpack itself.

dzuelke commented 5 years ago

s/not/now ;)

Yes, sorry for never closing this; it's been supported since v121 in March 2017...