heroku / heroku-buildpack-php

Heroku's classic buildpack for PHP applications.
https://devcenter.heroku.com/categories/php-support
MIT License
808 stars 1.59k forks source link

Fix bogus suffix warnings in autotune.php #691

Closed dzuelke closed 9 months ago

dzuelke commented 9 months ago

If the ! is_numeric() case statement evaluates to false, and the suffix is a 0 (e.g. because the input value is "2684354560" a.k.a. 2.5 GiB), it matches, and prints the warning.

This is not how case statements work (they simply weak-comparison match the switch value against the case expression). The check was supposed to be in the default block all along.