heroku / heroku-buildpack-php

Heroku's buildpack for PHP applications.
https://devcenter.heroku.com/categories/php
MIT License
805 stars 1.59k forks source link

V8JS Extension #80

Open peterkeen opened 10 years ago

peterkeen commented 10 years ago

Could we please get access to the v8js extension?

http://php.net/manual/en/book.v8js.php

cihantas commented 8 years ago

I'd also be happy if v8js would be included in the official Heroku php buildpack.

dzuelke commented 8 years ago

I don't think we will support it anytime soon. You can build and use the extension yourself without running a forked buildpack; see https://github.com/heroku/heroku-buildpack-php/blob/master/README.md#custom-platform-repositories for instructions.

hacfi commented 8 years ago

@peterkeen @cihantas Have a look at http://stesie.github.io/2015/11/v8js-buildpack - that might it up & running on Heroku!

dzuelke commented 8 years ago

That no longer works, or at least is no longer advisable, @hacfi. The buildpack can now natively use additional repositories with runtimes or extensions, no forking necessary (except for the person who maintains the repository with e.g. a V8JS extension, it's easier to maintain that way, but even that person will run actual applications using the official buildpack).

hacfi commented 8 years ago

@dzuelke Thanks for the quick response and the clarification!

dzuelke commented 8 years ago

Maybe @stesie can rework #134 to use the new platform repo infrastructure, and then someone can host the extension in an S3 bucket? :)

stesie commented 8 years ago

here we go ...

Github repo with the build formulas is at https://github.com/phpv8/heroku-v8js/tree/master

I've just built V8 version 5.0.71.25 and php-v8js itself (in latest release versions, i.e. 0.6.2 for PHP 5 and 1.2.0 for PHP 7). Just published to a new S3 bucket heroku-v8js of my own (let's see how much traffic that will cost) ...

To use it simply use default php buildpack with following extra setting:

heroku config:set HEROKU_PHP_PLATFORM_REPOSITORIES="https://heroku-v8js.s3.amazonaws.com/dist-cedar-14-stable/packages.json"
dzuelke commented 8 years ago

Works beautifully, great job @stesie!

dzuelke commented 8 years ago

@stesie can you please allow public listing on that bucket? You can now (see develop branch and 30f97f8) also use UPSTREAM_S3_BUCKET and UPSTREAM_S3_PREFIX, then you don't have to worry about having those PHP dependencies in your bucket for building.

stesie commented 8 years ago

@dzuelke public listing on heroku-v8js bucket is now enabled.

matiosfree commented 5 years ago

Still have the same issue. phpv8/heroku-v8js doesn't wotk with heroku-18. When I run composer update I get: "The request PHP extension ext-v8js * is missing from your system. Install or enable PHP's v8js extension."

I would like to make SEO friendly web apps