search

heroku / heroku-buildpack-python

Heroku's buildpack for Python applications.
https://www.heroku.com/python
MIT License
977 stars 1.84k forks source link

pip-grep not working to detect cffi #311

Closed axe-me closed 8 years ago

axe-me commented 8 years ago

seems this line is actually fail to dectect cffi https://github.com/heroku/heroku-buildpack-python/blob/master/bin/steps/cryptography#L23

and please add scrapy into the list after fixed this problem.

kennethreitz commented 8 years ago

cffi should be detected properly. Can you provide the requirements.txt file you are using?

axe-me commented 8 years ago 
cffi
gunicorn==19.4.5
Flask==0.11.1
Scrapy==1.1.0
py2neo==3.0.0
scrapyd==1.1.0
scrapyd-client==1.0.1
python-scrapyd-api==2.0.1

I think this is related to https://github.com/kennethreitz/pip-pop/pull/12

kennethreitz commented 8 years ago

It is not.

axe-me commented 8 years ago

ok... :) anyway, I got to fork this repo and remove that line in order to get libffi.