Django does find GEOS libraries on Heroku-16

codingjoe commented 7 years ago

I'm getting an ImportError from Django when switching to the heroku-16 stack.

File "/app/.heroku/python/lib/python3.6/site-packages/django/contrib/gis/geos/libgeos.py", line 57, in load_geos
'", "'.join(lib_names)
ImportError: Could not find the GEOS library (tried "geos_c", "GEOS"). Try setting GEOS_LIBRARY_PATH in your settings.

After some digging, I don't see the difference. The libraries are installed and the LD_LIBRARY_PATH is still the same as it used to be on cedar-14.

I could fix the issue for me by setting GEOS_LIBRARY_PATH explicitly in the post_compile hook.

bin/post_compile

#!/usr/bin/env bash

set -e

export GEOS_LIBRARY_PATH="$BUILD_DIR/.heroku/vendor/lib"

kennethreitz commented 7 years ago

@codingjoe did setting GOES_LIBRARY_PATH fix the issue for you?

codingjoe commented 7 years ago

@kennethreitz nope, when connecting to a run dyno yes. But post_compile is than only available during build, not during runtime. I'm investigating...

codingjoe commented 7 years ago

Scratch that, it did not work. Hm... strange....

edmorley commented 7 years ago

Reading the Django source, I believe GOES_LIBRARY_PATH needs to be set in Django settings rather than directly in the environment (though likely worth setting that via os.environ / the django-environ package): https://github.com/django/django/blob/1.11.2/django/contrib/gis/geos/libgeos.py

Strange that it's still not working out of the box however.

Fwiw I tried comparing the directory structure of the cedar-14 and heroku-16 geos archives (eg https://lang-python.s3.amazonaws.com/heroku-16/libraries/vendor/geos.tar.gz), and they are identical - so the difference isn't say an inadvertent change in location.

kennethreitz commented 7 years ago

I believe the GEOS libraries aren't functional on heroku-16, even though they're identical copies to the working ones on cedar-14. The binary needs to be rebuilt for heroku-16, but i'm having trouble doing so. Might take another approach, possibly (adding it to the build stack image).

codingjoe commented 7 years ago

@kennethreitz yes, that would be cool. I'd love to switch to heroku-16

kennethreitz commented 7 years ago

I think I figured out a way to run the build. Executing now. Will post an update if it succeeds.

maiksprenger commented 7 years ago

Hi @kennethreitz, did you have a chance to investigate this further? If I'm not mistaken, this is an issue for all GeoDjango installations on Heroku. I'm happy to have a look - could you share your progress so far?

kennethreitz commented 7 years ago

This should be fixed shortly, as soon as the build is complete!

kennethreitz commented 7 years ago

Build complete!

kennethreitz commented 7 years ago

✨🍰✨

maiksprenger commented 7 years ago

Good stuff, thanks Kenneth!

harelw commented 6 years ago

To get GeoDjango working I also had to set the following Config Variables:

GDAL_LIBRARY_PATH=/app/.heroku/vendor/lib/libgdal.so
GEOS_LIBRARY_PATH=/app/.heroku/vendor/lib/libgeos_c.so

Shouldn't the buildpack take care of this when BUILD_WITH_GEO_LIBRARIES=1 is set?

kennethreitz commented 6 years ago

@harelw on which stack?

harelw commented 6 years ago

heroku-16

kennethreitz commented 6 years ago

I'll have to experiment with that myself. If true, the buildpack can definitely do that for you.