search

heroku / heroku-buildpack-ruby

Heroku's buildpack for Ruby applications.
MIT License
787 stars 1.87k forks source link

Testing for 1452 - Fix propshaft compatibility #1453

Closed schneems closed 4 months ago

schneems commented 4 months ago

Testing for https://github.com/heroku/heroku-buildpack-ruby/pull/1452

edmorley commented 4 months ago

@schneems You don't need to open a new PR for these - instead clone the commits and push to a branch on the repo as-is - the CI result will be posted to the original PR too (since GitHub's status checks API uses the SHA256 as the identifier for the CI result - not the PR/branch reference, so the most recent CI result for that SHA256 will show up on the original PR). Doing it this way means (a) no need to ask someone else for review (you can review the original PR yourself), (b) the original PR author gets full attribution for the merged PR.

In the event that you need to make additional changes to the contributed PR, you can still use the above workflow, but instead also need to push those commits to their PR branch (GitHub defaults to allowing you to push to the branches of a fork, when a PR is opened from that fork) in addition to the non-fork repo push.

schneems commented 4 months ago

Thanks. In the past the compliance check never finishes. It didn't here either. But I was able to "re-sync" with github and then it worked.