search

heroku / heroku-buildpack-secret-buddy

Secretbuddy Buildpack
Apache License 2.0
0 stars 3 forks source link

Removing debugging output from `bin/compile` #25

Open edmorley opened 8 months ago

edmorley commented 8 months ago

Currently the bin/compile script contains a fair amount of additional output (eg lots of ls -al calls, and debugging echos) that is presumably leftover from testing/development:

https://github.com/heroku/heroku-buildpack-secret-buddy/blob/53b251389f58275cb7b3129f844f5b6763b10476/bin/compile#L41-L58

edmorley commented 5 months ago

An example of what this looks like in a build log:

-----> Building on the Heroku-24 stack
-----> Using buildpacks:
       1. https://github.com/heroku/heroku-buildpack-secret-buddy
       2. heroku/go
-----> SecretBuddy Fun Times app detected
/tmp/codon/tmp/buildpacks/b521f61dad9d4aa1bf5a488d5c02f97462f662db
BUILDPACK
/tmp/codon/tmp/buildpacks/b521f61dad9d4aa1bf5a488d5c02f97462f662db/secret-buddy-buildpack
total 2380
drwxr-xr-x  7 heroku heroku    4096 May 31 07:00 .
drwxr-xr-x 12 heroku heroku    4096 May 31 07:00 ..
drwxr-xr-x  2 heroku heroku    4096 May 31 07:00 bin
-rw-r--r--  1 heroku heroku    5158 May 31 07:00 CODE_OF_CONDUCT.md
-rw-r--r--  1 heroku heroku     197 May 31 07:00 CODEOWNERS
drwxr-xr-x  2 heroku heroku    4096 May 31 07:00 docs
drwxr-xr-x  8 heroku heroku    4096 May 31 07:00 .git
drwxr-xr-x  3 heroku heroku    4096 May 31 07:00 .github
-rw-r--r--  1 heroku heroku     287 May 31 07:00 .gitignore
-rw-r--r--  1 heroku heroku      46 May 31 07:00 go.mod
-rw-r--r--  1 heroku heroku   11411 May 31 07:00 LICENSE
-rw-r--r--  1 heroku heroku   10077 May 31 07:00 license_info.md
-rw-r--r--  1 heroku heroku     111 May 31 07:00 Makefile
drwxr-xr-x  2 heroku heroku    4096 May 31 07:00 profile
-rw-r--r--  1 heroku heroku     146 May 31 07:00 README.md
-rwxr-xr-x  1 heroku heroku 2339702 May 31 07:00 secret-buddy-buildpack
-rw-r--r--  1 heroku heroku    3135 May 31 07:00 secret-buddy-buildpack.go
-rw-r--r--  1 heroku heroku    4037 May 31 07:00 secret-buddy-buildpack_test.go
-rw-r--r--  1 heroku heroku     400 May 31 07:00 SECURITY.md
-rwxr-xr-x 1 heroku heroku 2339702 May 31 07:00 /tmp/codon/tmp/buildpacks/b521f61dad9d4aa1bf5a488d5c02f97462f662db/secret-buddy-buildpack
Copying buildpack exec to /tmp/build_76893ad4/.profile.d/secret-buddy-buildpack
BUILD_DIR: /tmp/build_76893ad4
total 96
drwx--x--- 10 heroku heroku 4096 May 31 07:00 .
drwxrwsr-x  5 root   heroku 4096 May 31 07:00 ..
-rw-r--r--  1 heroku heroku  393 May  3 20:38 app.json
drwxr-sr-x  2 heroku heroku 4096 May  3 20:38 bin
-rw-r--r--  1 heroku heroku 2373 May  3 20:38 build_test.go
drwxr-sr-x  3 heroku heroku 4096 May  3 20:38 cmd
drwxr-sr-x  2 heroku heroku 4096 May  3 20:38 config
-rw-r--r--  1 heroku heroku   54 May  3 20:38 .env.sample
-rw-r--r--  1 heroku heroku 1811 May  3 20:38 exports_test.go
drwxr-sr-x  3 heroku heroku 4096 May  3 20:38 .github
-rw-r--r--  1 heroku heroku   90 May  3 20:38 .gitignore
-rw-r--r--  1 heroku heroku  949 May  3 20:38 go.mod
-rw-r--r--  1 heroku heroku 7969 May  3 20:38 go.sum
-rw-r--r--  1 heroku heroku 1081 May  3 20:38 LICENSE
-rw-r--r--  1 heroku heroku  471 May  3 20:38 Makefile
-rw-r--r--  1 heroku heroku   15 May  3 20:38 Procfile
drwxr-xr-x  2 heroku heroku 4096 May 31 07:00 .profile.d
-rw-r--r--  1 heroku heroku 2158 May  3 20:38 README.md
-rw-r--r--  1 heroku heroku 2030 May  3 20:38 releaser.go
-rw-r--r--  1 heroku heroku 3560 May  3 20:38 releaser_test.go
drwxr-sr-x  2 heroku heroku 4096 May  3 20:38 sbin
drwxr-sr-x  2 heroku heroku 4096 May  3 20:38 server
drwxr-sr-x  3 heroku heroku 4096 May  3 20:38 test
BUILD_DIR/.profile.d
total 2300
drwxr-xr-x  2 heroku heroku    4096 May 31 07:00 .
drwx--x--- 10 heroku heroku    4096 May 31 07:00 ..
-rwxr-xr-x  1 heroku heroku 2339702 May 31 07:00 secret-buddy-buildpack
-rw-r--r--  1 heroku heroku     190 May 31 07:00 secret-buddy.sh
-----> Go app detected
...