search

heroku / heroku-buildpack-static

[DEPRECATED] Heroku buildpack for handling static sites and single page web apps
MIT License
673 stars 427 forks source link

Buildkits (codon-buildpacks) copy of the published buildpack is out of date #187

Closed edmorley closed 3 years ago

edmorley commented 3 years ago

The Buildkits service was replaced by the Buildpack Registry, however there are still some buildpack consumers using the legacy buildkit URLs (that use the codon-buildpacks S3 bucket) instead of the buildpack registry URLs.

Currently the static buildpack isn't on the list of buildpacks synced from the new bucket back to the old, meaning the copy of the buildpack in the old bucket is out of date, and doesn't have the fix for #182 amongst other things.

$ curl -IsSf https://codon-buildpacks.s3.amazonaws.com/buildpacks/heroku/static.tgz | rg '(Last-Modified|ETag)'
Last-Modified: Wed, 14 Jun 2017 21:49:52 GMT
ETag: "7932356db2be01178a3c931e39c115ee"

$ curl -IsSf https://buildpack-registry.s3.amazonaws.com/buildpacks/heroku-community/static.tgz | rg '(Last-Modified|ETag)'
Last-Modified: Wed, 11 Nov 2020 10:35:03 GMT
ETag: "5668d98bb5ee7fa36f776d773b537a4a"

This is causing eg: heroku/heroku-buildpack-emberjs/issues/65

Whilst long term we would like to remove the last usages of the old bucket, for now we should add this buildpack to the sync list.

Refs W-8480774.

edmorley commented 3 years ago

Looking at the published buildkits archive (and diffing against the buildpack registry version), I see the last change that is included in the former is that from #78.

As such the diff between the two is: https://github.com/heroku/heroku-buildpack-static/compare/995b07c1df7971c66d1c921f2c55132a2dca57ca...v5

edmorley commented 3 years ago

I've appended the static buildpack's mapping to buildkit's BUILDPACKS_TO_SYNC.

The buildpack has now been synced:

$ curl -IsSf https://codon-buildpacks.s3.amazonaws.com/buildpacks/heroku/static.tgz | rg '(Last-Modified|ETag)'
Last-Modified: Sun, 22 Nov 2020 17:20:16 GMT
ETag: "5668d98bb5ee7fa36f776d773b537a4a"