search

heroku / heroku-buildpack-static

[DEPRECATED] Heroku buildpack for handling static sites and single page web apps
MIT License
675 stars 427 forks source link

Following migration guide results in `bin/config/make-config: No such file or directory` #247

Open bean5 opened 2 years ago

bean5 commented 2 years ago

Expected This just works OR is marked as deprecated at https://elements.heroku.com/buildpacks/heroku/heroku-buildpack-static

Actual Not marked directly as deprecated.

Background I started using this project just to find out it is deprecated and then discover that the conversion steps are broken. That's lost work for me for a new projects. At least I failed fast. I could have failed faster, though, if the project was labeled clearly as deprecated on heroku website itself. In github it is marked as deprecated and at run-time it is marked. On heroku, though, it is not.

Usually heroku tools are so easy for me to use, I have come to expect that it just works without much reading. This one surprised me. I think there is an easy fix hiding around here.

Rather than fix, perhaps it is time to just mark this as deprecated at https://elements.heroku.com/buildpacks/heroku/heroku-buildpack-static. I

This is what is being outputted when I use this:

remote:        ## WARNING: `heroku-buildpack-static` is deprecated
remote: 
remote:        This buildpack is deprecated and is no longer being maintained.
remote:        If you are using this project, you can transition over to NGINX via an NGINX buildpack.
remote:        Use your project's existing configuration.
remote:        To find the NGINX configuration generated by the heroku-buildpack-static you can run:
remote: 
remote:        ```
remote:        $ heroku run bash
remote:        ~ $ bin/config/make-config
remote:        ~ $ cat config/nginx.conf
remote:        ```
zuehlke-silo commented 1 year ago

Same

geralddevelop commented 1 year ago

hi do you have any solution to this?

edmorley commented 11 months ago

Hi!

The bin/config/make-config script mentioned in the conversion steps does exist - but it requires that your app have been built at least once with this buildpack first. It's intended to be a way to migrate an existing app to the NGINX buildpack, not a way to start using NGINX from scratch for a new app.

Regarding https://elements.heroku.com/buildpacks/heroku/heroku-buildpack-static being out of date - thank you for letting us know, I'll pass the message on to the team that owns that site. I presume some sync process isn't working as expected - the content there comes from the GitHub repo, and the GitHub repo was updated to mention the deprecation long ago.