search

heroku / heroku-django-template

A Django 2.0 base template featuring all recommended best practices for deployment on Heroku and local development.
https://www.heroku.com/python
903 stars 0 forks source link

Upgraded to Django 3.0 maybe? #103

Open louisluhao opened 4 years ago

louisluhao commented 4 years ago

Or maybe have a separate repo for Django 3.0 template.

niniack commented 4 years ago

Agreed! @ Project Maintainers If PRs for this are welcome, I'd like to take a shot at this!

hkennyv commented 4 years ago

+1. Would love to see this. I'd be open to contributing as well since it looks like the last commit was in 2018

niniack commented 4 years ago

I tried it out, seems that nothing actually had to be changed to reflect the move to Django 3. The comments/about/README just have to change to show that. There was virtually no difference in the template compared to other projects I've done without using a template.

The template seemed to make use of the package dj-database-url but this was missing in the Pipfile, which led to missing module error when deploying to Heroku. Threw that in there. Tested with the changes I made, works as expected!