heroku / heroku-exec-util

ISC License
2 stars 6 forks source link

Got version 11.8.6 throws an error with auth option. #40

Open mijoharas opened 3 months ago

mijoharas commented 3 months ago

yarn.lock in this package specifies got version 11.8.6, which throws an error when given the auth option here.

The base heroku-cli has multiple versions of got so I think this might be a module resolution issue.

Full explanation: As recommended in the docs I'm using the arch package. ref.

This package removes the pin on node, and reinstalls the dependencies, which removes alternate versions of the got dependency. ref

on my machine.

$ cat yarn.lock | grep '/got/' | grep resolved
  resolved "https://registry.yarnpkg.com/got/-/got-11.8.6.tgz#276e827ead8772eddbcfc97170590b841823233a"

This version of got throws an error if you try and pass auth as an option to it, and triggers an error in ps:exec in the updateClientKey function here. This calls got and throws a TypeError here.

Solutions are either re-introduce the node pinning in the aur package, or update heroku-cli-exec to use username/password. Let me see about making a PR for that.

internal support ticket: https://help.heroku.com/1417095