search

heroku / heroku-geo-buildpack

37 stars 26 forks source link

Use cache busting to ensure apt-get update runs correctly #3

Closed thclark closed 4 years ago

thclark commented 4 years ago

I'll leave this to the maintainers in case there's a reason for it I haven't seen; but I believe apt-get update and apt-get install should be on the same line (in the dockerfile here), based on the best practices from docker (scroll down to 'APT-GET' section).

KevinBrolly commented 4 years ago

Hey @thclark - I found a direct link to the recommendations - https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#apt-get

I have made this change now, thanks for another great suggestion!