Fix bug when doing an version check with \timing on

heroku / heroku-pg-extras

A heroku plugin for awesome pg:* commands that are also great and fun and super.

MIT License

1.33k stars 102 forks source link

Fix bug when doing an version check with \timing on #184

Closed andscoop closed 2 years ago

andscoop commented 3 years ago

This PR allows the version check to execute with or without \timing enabled while still allowing us to guard against index out of range errors.

Fixes: https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07B0000008x6klIAA/view

andscoop commented 3 years ago

This PR will depend on https://github.com/heroku/cli/pull/1801 being released

iriberri commented 2 years ago

@andscoop just noticed the depending PR got merged! There are some conflicts now but should we go ahead with this? We've seen another case where PG version detection isn't correct (although I haven't been able to find why yet) and I think this should fix it too.