search

heroku / heroku-repo

Plugin for heroku CLI that can manipulate the repo
MIT License
686 stars 111 forks source link

never run aggressive #18

Closed wuputah closed 1 year ago

wuputah commented 10 years ago

aggressive is a very intensive and most likely unneeded task that is unlikely to finish in a dyno. for more on aggressive, see: http://metalinguist.wordpress.com/2007/12/06/the-woes-of-git-gc-aggressive-and-how-git-deltas-work/

tt commented 10 years ago

Should we perhaps leave it as a flag? Perhaps the arguments to heroku repo:gc would just be passed to git gc. Then you'd also be able to set --prune, if you wanted to.

wuputah commented 10 years ago

Perhaps, but I don't know how to do that. In any case, I think the most sane default is definitely not --aggressive.

lstoll commented 10 years ago

I'd definitely say drop the --agressive by default. I originally did this for a handful of specific people who were doing very Dumb Things with their repos, who needed a crazy level of fixing. The general case should be a normal GC. I do like the idea of just passing through args to the git gc command, sounds neat and way more flexible.