heroku / heroku-repo

Plugin for heroku CLI that can manipulate the repo
MIT License
686 stars 111 forks source link

Remove Rebuild Command #23

Closed naaman closed 9 years ago

naaman commented 10 years ago

Rebuilding this way can cause conflicts. It's better to use the Build API for rebuild.

naaman commented 10 years ago

/cc @heroku/support @heroku/languages

chadbailey59 commented 10 years ago

@naaman If we remove this, is there documentation handy for how to do this with the Build API?

Also, @heroku/support, does anyone else use this command instead of just using repo:reset with customer permission?

naaman commented 10 years ago

@chadbailey59 This is the best doc available: https://devcenter.heroku.com/articles/build-and-release-using-the-api

The concern I have right now is that people are beginning to use this command even though it's undocumented and can lead to incorrect assumptions about what's being built.

tt commented 10 years ago

:+1:

chadbailey59 commented 10 years ago

:thumbsup: to removing rebuild, but can we update the help for the reset command to something like "Removes the contents of Heroku's copy of the repository"?

On Tue, Jul 15, 2014 at 3:49 AM, Troels Thomsen notifications@github.com wrote:

[image: :+1:]

— Reply to this email directly or view it on GitHub https://github.com/heroku/heroku-repo/pull/23#issuecomment-49005734.

catsby commented 9 years ago

I got an email about this merge – GitHub claims I'm on a team mentioned here?

confused

also, hi everyone!

jacobian commented 9 years ago

@catsby super weird, and according to what I can see you're not actually part of those teams.... I've pinged github support to see if they can help figure out what even happened. Thanks for the heads-up :)

mattmanning commented 9 years ago

I'm somehow on this thread, too.

-Matt

On Fri, May 29, 2015 at 10:57 AM, Jacob Kaplan-Moss < notifications@github.com> wrote:

@catsby https://github.com/catsby super weird, and according to what I can see you're not actually part of those teams.... I've pinged github support to see if they can help figure out what even happened. Thanks for the heads-up :)

— Reply to this email directly or view it on GitHub https://github.com/heroku/heroku-repo/pull/23#issuecomment-106889243.

catsby commented 9 years ago

I wish I grabbed a screen shot, but this "Notifications" block this morning said "you're receiving notifications because you're on a team that was mentioned" (or similar)

screen shot 2015-05-29 at 3 14 00 pm

At the time, I clicked all the named teams and all of them 404'd

jacobian commented 9 years ago

@catsby OK heard back from Github, and they've said:

The catsby account isn't currently a member of the heroku organization or any teams within it, but on 7/14/14 catsby was a member of the heroku/support team Since the repository is public, his account wasn't unsubscribed from the PR when he was removed from the organization. This wouldn't have been the case if the PR was in a private repository.

Which is a bit odd, but makes some sense.

catsby commented 9 years ago

Thanks for following up Jacob, glad that's sorted :+1:

dblackdblack commented 8 years ago

Wait you guys seriously removed a super useful feature from a command line tool and replaced with ... curl? :-1:

If you want to change the backend implementation so that it does an HTTP request, that's fine by me, but I'm not going to pore over your REST API docs trying to figure this out. Instead I'll just add an empty commit and then force push over the top of it, which results in two builds and clutters up my release history. I imagine this is what most people will do and it seems to be the thing that people on the internet are telling everyone to do. It's a horrible hack and you had a wonderful solution for it but then ripped it out.

fj commented 8 years ago

@dblackdblack No need to force push or make spurious commits; use heroku repo:reset and then git push heroku.

d4goxn commented 8 years ago

@dblackdblack hero repo:reset - doesn't that take the site offline?

dmathieu commented 8 years ago

No, heroku repo:reset does not take the site offline.

bennycode commented 7 years ago

Using heroku repo:reset shows repo:reset is not a heroku command. Is anyone else experiencing that?

keiko713 commented 7 years ago

@bennyn did you install a plugin using heroku plugins:install heroku-repo (see https://github.com/heroku/heroku-repo#installation)? Also, are you using the latest version of Heroku CLI (https://devcenter.heroku.com/articles/heroku-cli#staying-up-to-date)?

bennycode commented 7 years ago

@keiko713: Thanks for the fast answer! I missed heroku plugins:install heroku-repo. 🙈

achikin commented 5 years ago
→ git push heroku
fatal: 'heroku' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
mattmanning commented 5 years ago

This sounds like you need to add a "heroku" remote in your local git repo.

https://devcenter.heroku.com/articles/git#creating-a-heroku-remote

On Tue, Oct 16, 2018 at 5:10 AM Anton Chikin notifications@github.com wrote:

→ git push heroku fatal: 'heroku' does not appear to be a git repository fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/heroku/heroku-repo/pull/23#issuecomment-430161570, or mute the thread https://github.com/notifications/unsubscribe-auth/AACuR7xsia7cM_uBR91NdLSQePD53mhDks5ulaJwgaJpZM4CNGw6 .

achikin commented 5 years ago

@mattmanning we don't use remotes to deploy - we have a hook on a branch instead.

dmathieu commented 5 years ago

You can't use git push heroku then. That command requires a remote. See https://git-scm.com/docs/git-push