search

heroku / heroku-repo

Plugin for heroku CLI that can manipulate the repo
MIT License
686 stars 111 forks source link

repo:purge_cache when there is nothing to purge #36

Closed cyx closed 6 years ago

cyx commented 9 years ago

If for some reason the cache_get_url results in a 404 (maybe due to an old version of the plugin being used), we get a cryptic error when running the command.

Perhaps we can just silently fail / run without showing any errors for cases like this.

edmorley commented 6 years ago

This is fixed in the new builds:cache:purge command added to heroku-builds that is replacing the repo:purge_cache command in this repo (see #77):

treeherder $ ths builds:cache:purge
Purging build cache for treeherder-stage... done
treeherder $ ths builds:cache:purge
Purging build cache for treeherder-stage... done

(ths is an alias for HEROKU_APP=treeherder-stage heroku)

As such, I think this can now be closed.

dmathieu commented 6 years ago

Thank you @edmorley

econner commented 5 years ago

Hello from 2019. Are we not supposed to be using the purge_cache command in heroku repo? As of 2017 it was going to be replaced?