heroku / heroku-sbt-plugin

An sbt plugin for deploying Heroku Scala applications
MIT License
111 stars 17 forks source link

support for .jdk-overlay folder into the packaged jdk #18

Closed ggmoriyon closed 9 years ago

ggmoriyon commented 9 years ago

First of all, thank you for your great effort. I find this sbt plugin very useful for using jenkins as the way to deploy into Heroku.

Sometimes, there is a need to extend the default jdk bundled in Heroku. For example, when requiring Java JCE in your project. Heroku enables the jdk customization mechanism to extend the bundled jdk as documented in https://devcenter.heroku.com/articles/customizing-the-jdk

I have created a sample project to show this: https://github.com/ggmoriyon/sbt-heroku-include-jdk-overlay-sample

To reproduce the current behavior:

jkutner commented 9 years ago

Yes, makes perfect sense, and should be easy to do. It will increase parity with the buildpack, which is a good thing.

I'll should be able to knock this out very soon, and have a release early next week.

jkutner commented 9 years ago

This will be available in version 0.3.6 (or 0.4.0 because I might bump in this release). I expect to deploy it on Friday.

ggmoriyon commented 9 years ago

that's great news Joe! thanks!