Currently this command honors HEROKU_HTTP_PROXY_ env vars when it talks to the Heroku API but not when it downloads the slug from S3. This PR adds proxy support to the download step.
Verify that the slug downloads correctly and requests go via the proxy
Download a slug without the proxy:
heroku slugs:download -a <your-app> <slug-uuid>
Verify that the slug downloaded correctly
Why not use global-agent?
global-agent expects a single env var (with host and port) whereas the existing heroku-client expects two separate env vars. It seemed overall simpler to rig things up to match the existing heroku-client behavior.
Why the change?
Currently this command honors
HEROKU_HTTP_PROXY_
env vars when it talks to the Heroku API but not when it downloads the slug from S3. This PR adds proxy support to the download step.How do I verify this?
How do I do all that with mitmproxy?
localhost:8080
.Why not use global-agent?
global-agent expects a single env var (with host and port) whereas the existing heroku-client expects two separate env vars. It seemed overall simpler to rig things up to match the existing heroku-client behavior.