heroku / heroku-two-factor

Deprecated - see our updated docs.
https://devcenter.heroku.com/articles/two-factor-authentication
0 stars 0 forks source link

enabling 2fa fails with a ruby exception #42

Closed curzonj closed 10 years ago

curzonj commented 10 years ago
~ $ heroku 2fa:enable
WARN: this will change your API key, and expire it every 30 days!
To enable scan the QR rendered below then login again.

 !    Heroku client internal error.
 !    Search for help at: https://help.heroku.com
 !    Or report a bug at: https://github.com/heroku/heroku/issues/new

    Error:       The passed data is NilClass, not String (RQRCode::QRCodeArgumentError)
    Backtrace:   /Users/jcurzon/.heroku/plugins/heroku-two-factor/vendor/rqrcode-0.4.2/lib/rqrcode/qrcode/qr_code.rb:88:in `initialize'
                 /Users/jcurzon/.heroku/plugins/heroku-two-factor/init.rb:108:in `new'
                 /Users/jcurzon/.heroku/plugins/heroku-two-factor/init.rb:108:in `render_qrcode'
                 /Users/jcurzon/.heroku/plugins/heroku-two-factor/init.rb:39:in `enable'
                 /Users/jcurzon/.rvm/gems/ruby-2.0.0-p353/gems/heroku-3.6.0/lib/heroku/command.rb:218:in `run'
                 /Users/jcurzon/.rvm/gems/ruby-2.0.0-p353/gems/heroku-3.6.0/lib/heroku/cli.rb:28:in `start'
                 /Users/jcurzon/.rvm/gems/ruby-2.0.0-p353/gems/heroku-3.6.0/bin/heroku:17:in `<top (required)>'
                 /Users/jcurzon/.rvm/gems/ruby-2.0.0-p353/bin/heroku:23:in `load'
                 /Users/jcurzon/.rvm/gems/ruby-2.0.0-p353/bin/heroku:23:in `<main>'
                 /Users/jcurzon/.rvm/gems/ruby-2.0.0-p353/bin/ruby_executable_hooks:15:in `eval'
                 /Users/jcurzon/.rvm/gems/ruby-2.0.0-p353/bin/ruby_executable_hooks:15:in `<main>'

    Command:     heroku 2fa:enable
    Plugins:     heroku-two-factor

    Version:     heroku-gem/3.6.0 (x86_64-darwin12.5.0) ruby/2.0.0
brandur commented 10 years ago

@curzonj Did this just happen one time or is it reproducible?

Also, can you make sure to run plugins:update and see if it still happens for you? There's still a lot of flux happening inside the code base.

curzonj commented 10 years ago

It was reproducible, but plugins:update fixed it for me. Thanks.

brandur commented 10 years ago

Excellent! Thanks for checking.

brandur commented 10 years ago

LOL GitHub AJAX FTL.