search

heroku / heroku-two-factor

Deprecated - see our updated docs.
https://devcenter.heroku.com/articles/two-factor-authentication
4 stars 3 forks source link

Asks for 2fa for accounts with out 2fa enabled #47

Closed jesperfj closed 10 years ago

jesperfj commented 10 years ago

I have one account with 2FA enabled and one without. When I log into the account without 2FA using heroku login, I am prompted for a 2FA code. I can type any code and it will log me in, but that still seems to be a bug.

friism commented 10 years ago

Yeah, hopefully this will go away when plugin is folded into toolbelt.

max commented 10 years ago

How would this go away when it's folded in?

markpundsack commented 10 years ago

Hmm... I was told this didn't happen anymore. Regression or misinformation?

jesperfj commented 10 years ago

I think I saw it about a week ago. Perhaps old bug report at this point...

On Tue, Apr 29, 2014 at 9:53 AM, Mark Pundsack notifications@github.comwrote:

Hmm... I was told this didn't happen anymore. Regression or misinformation?

— Reply to this email directly or view it on GitHubhttps://github.com/heroku/heroku-two-factor/issues/47#issuecomment-41701976 .

brandur commented 10 years ago

@jesperfj Can you make sure you have your plugin updated? I made a bunch of changes around this a few weeks ago, and you should only ever be asked for a 2FA code now if the API tells your client that it needs one (i.e. sees the Heroku-Two-Factor-Required header).

Let us know if it's still a problem!

jesperfj commented 10 years ago

Ran plugins:update and I am not seeing the issue any more.