Deleting collaborators with email addresses that include a plus.

djhopper01 commented 11 years ago

When using the actual API, trying to delete a collaborator with an email format of email+token@example.com returns a 404.

Heroku::API::Errors::NotFound: Expected(200) <=> Actual(404 Not Found)

I was able to solve this in my application by replacing + with %2B before making the call to delete_collaborator.

I added a test for deleting a collaborator, but this test currently passes. This problem doesn't seem like its too big of an issue, but I'm just curious as to what you guys think. I haven't dove into heroku.rb to think about a solution yet.

geemus commented 11 years ago

@djhopper01 - hmm. It is quite possible that we should just URI encode any/all emails before passing them on in the collaborator stuff in order to avoid this issue. I think that would get you what you needed anyway.

djhopper01 commented 11 years ago

Yep, that's what I was thinking as well. I'll continue working on this and push an update soon.

geemus commented 11 years ago

@djhopper01 - sounds great, look forward to it.

geemus commented 10 years ago

I'll just take it from here. Thanks!

heroku / heroku.rb

Deleting collaborators with email addresses that include a plus. #64