search

heroku / heroku.rb

DEPRECATED! Official Heroku Ruby Legacy API wrapper
161 stars 41 forks source link

Add process types #66

Closed jonmountjoy closed 11 years ago

jonmountjoy commented 11 years ago

Add process types to the client so that I can modify the CLI to show process types for an app.

coop commented 11 years ago

@jonmountjoy this is a change that I'd love to see merged, I'd be willing to make the change if you don't have time.

jonmountjoy commented 11 years ago

Thanks @coop but I believe there are other blockers to this integration (folk considering alternative displays - perhaps modifying the basic ps command)

coop commented 11 years ago

I'm specifically interested in getting heroku.get_types(APP) merged. Would it be worth moving this out into a separate pull request?

geemus commented 11 years ago

@jonmountjoy - I'm fine merging with just that change I think. What you mention is a whole other can of worms, but one that we can disregard in this context, for now, I think.

jonmountjoy commented 11 years ago

Do you need anything from me to do that @geemus ?

geemus commented 11 years ago

@jonmountjoy I think you covered it. Thanks!

jonmountjoy commented 11 years ago

:dancers: Thanks!

coop commented 11 years ago

I really appreciate it, thanks @jonmountjoy and @geemus!