search

heroku / heroku.rb

DEPRECATED! Official Heroku Ruby Legacy API wrapper
161 stars 41 forks source link

Better Error Messages #79

Closed schneems closed 10 years ago

schneems commented 10 years ago

Instead of getting this extremely unhelpful error message

Heroku::API::Errors::RequestFailed: Expected(202) <=> Actual(422 Unprocessable Entity)"

Now you would get

Heroku::API::Errors::RequestFailed: Expected(202) <=> Actual(422 Unprocessable Entity)
body: {\"id\":\"invalid_params\",\"error\":\"You've reached your app limit of 100 apps.\\nContact us at biz@heroku.com to have this limit increased.\"}"
geemus commented 10 years ago

@schneems seems good. The id/error format should be pretty consistent too, if you wanted to get to that level (instead of just inspecting the body). Still seems an improvement though. Thanks!

schneems commented 10 years ago

Any chance you could could cut a version for us to use this on the buildpack tests?

geemus commented 10 years ago

Looking at commits it appears that 0.3.17 happened after this merge, is that not the case?