search

heroku / heroku.rb

DEPRECATED! Official Heroku Ruby Legacy API wrapper
161 stars 41 forks source link

add support for dyno sizes with mocks #80

Closed fabiokung closed 10 years ago

fabiokung commented 10 years ago

This is required by the upcoming changes in the heroku CLI to support non-numeric dyno sizes.

fabiokung commented 10 years ago

This needs to be released before heroku/heroku#1010

geemus commented 10 years ago

@fabiokung - hmm. Appears to have test failures related to the change, though why it would only fail in 1.9.2 is a mystery to me. Could you take a look and see if you can get them cooperating? Thanks!

fabiokung commented 10 years ago

@geemus the test failures seem to be unrelated with the changes in here. They were failing in previous builds too, apparently since the switch to multi_json.

fabiokung commented 10 years ago

@geemus https://travis-ci.org/heroku/heroku.rb/builds/12622870

geemus commented 10 years ago

Oof. Fair enough.

geemus commented 10 years ago

Should now be released as 0.3.17