search

heroku / identity

[DEPRECATED] Login and OAuth management service for Heroku
https://id.heroku.com/
MIT License
246 stars 20 forks source link

Redirect sso on oauth #186

Closed kahlouie closed 8 years ago

kahlouie commented 8 years ago

This redirects to the sso url when you've been logged out.

naaman commented 8 years ago

@kahlouie Are we sure this is the right thing to do? /logout is an explicit logout, not session expiration. I think we're going to end up removing this when we implement the single logout.

kahlouie commented 8 years ago

@dmcinnes We decided this is the right path for the moment. I'm happy to talk about this a bit more one on one.

geemus commented 8 years ago

oops, misread that as decision against :(

kahlouie commented 8 years ago

@geemus no worries!

dmcinnes commented 8 years ago

LGTM, just that one comment!

dmcinnes commented 8 years ago

Thanks!