Include API helper in auth helper for #decode_error

heroku / identity

[DEPRECATED] Login and OAuth management service for Heroku

https://id.heroku.com/

MIT License

246 stars 20 forks source link

Include API helper in auth helper for #decode_error #204

Closed dmcinnes closed 8 years ago

dmcinnes commented 8 years ago

In certain cases call_authorize is called by a class that doesn't have the API helpers, so the call to decode_error will fail with a NoMethodError.

owenthereal commented 8 years ago

Is it the same error in https://github.com/heroku/identity/pull/205? If it is, it should be fixed.

dmcinnes commented 8 years ago

@jingweno I think this is a different error, it's coming from an SSO request and helper wasn't included on those endpoints. Better to do it right in the Auth helper.

dmcinnes commented 8 years ago

Pulling this in