search

heroku / identity

[DEPRECATED] Login and OAuth management service for Heroku
https://id.heroku.com/
MIT License
246 stars 20 forks source link

Make deny button a clickable link #220

Closed rwz closed 8 years ago

rwz commented 8 years ago

Apparently on our client authorization page where we had Accept/Deny buttons, deny button was never working properly.

Instead of acting as a dumb link and redirect user to the failure url via GET request, it was submitting the form with blank POST body and cause identity to respond with an unrelevant error.

This change makes it behave like intended. I also made sure that the page looks exactly the same with that change.

dmcinnes commented 8 years ago

Nice one :+1:

rwz commented 8 years ago

screen shot 2016-03-17 at 3 03 38 pm

spofdamon commented 8 years ago

:+1:

rwz commented 8 years ago

thanks