search

heroku / identity

[DEPRECATED] Login and OAuth management service for Heroku
https://id.heroku.com/
MIT License
246 stars 20 forks source link

Extract deny url into a helper method #221

Closed rwz closed 8 years ago

rwz commented 8 years ago

Apparently there were 4 places in the code where we've rendered clients/authorize template and @deny_url was only set in one of them. This PR extracts it into a helper method that allows the template to render the url without instance variable to be set explicitly. It relies on @client to be set though.

spofdamon commented 8 years ago

:+1:

rwz commented 8 years ago

@spofdamon thanks

dmcinnes commented 8 years ago

:+1: from me too