Update layout to use CDN for favicon

heroku / identity

[DEPRECATED] Login and OAuth management service for Heroku

https://id.heroku.com/

MIT License

246 stars 20 forks source link

Update layout to use CDN for favicon #235

Closed maxbeizer closed 7 years ago

maxbeizer commented 7 years ago

Instead of using an local asset for the favicon, this PR points the Heroku CDN which serves the favicon for many other Heroku properties. The main idea is behind this change is to keep the favicon up-to-date on identity and centralize the location of the favicon for future changes.

maxbeizer commented 7 years ago

cc @itchymutt

dmcinnes commented 7 years ago

LGTM! 👍

maxbeizer commented 7 years ago

thanks @dmcinnes !