search

heroku / kensa

A tool to help Heroku add-on providers integrate their services with Heroku
https://devcenter.heroku.com/articles/building-a-heroku-add-on
Other
90 stars 47 forks source link

Missing Sydney region #109

Open drusellers opened 7 years ago

drusellers commented 7 years ago

I'm looking at https://github.com/heroku/kensa/blob/master/lib/heroku/kensa/manifest.rb#L6 and it doesn't show sydney as a valid region. But according to https://devcenter.heroku.com/articles/add-on-manifest#api-regions it should be a valid region.

Am I missing something?

Thank you,

drusellers commented 7 years ago

The sydney announcement: https://devcenter.heroku.com/changelog-items/980

drusellers commented 7 years ago

We will need dublin too when that gets out of beta.

mathias commented 6 years ago

Hello,

Please try out our new replacement for Kensa, https://github.com/heroku/heroku-cli-addons-admin

It fetches the current public regions from the API when it generates manifests, so it should avoid needing to be updated like Kensa did.

Thanks!

drusellers commented 6 years ago

@mathias thank you, i will indeed check this out. Unless I'm missing something this new "admin" add-on does not exercise the local apps oauth dance like Kensa does - is that correct?

mathias commented 6 years ago

Yes, and Kensa was never going to support the new, OAuth-based provisioning flow (which we call Provisioning API V3: https://devcenter.heroku.com/articles/add-on-partner-api-reference )

Instead, we recommend that add-on partners write integration tests in their own codebase, so that they can be run with continuous integration, etc.