search

heroku / legacy-cli

Heroku CLI
https://cli.heroku.com
MIT License
1.37k stars 380 forks source link

Properly handle null web_url in addons:open #1819

Open ransombriggs opened 8 years ago

ransombriggs commented 8 years ago

If web_url is not defined, we bail out with a nasty message rather than a warning.

Error: Failure in opening uri nil with options {}: undefined method `to_hash' for nil:NilClass (Launchy::Error)

jdx commented 8 years ago

could we move this one to the addons plugin? https://github.com/heroku/heroku-cli-addons

ransombriggs commented 8 years ago

@dickeyxxx do you have a recommendation for what can replace launchy in node? I was thinking maybe this, but have not looked at it super deeply yet - https://www.npmjs.com/package/open

jdx commented 8 years ago

that project looks dead, but this looks like a decent one: https://github.com/sindresorhus/opn

On Mon, Nov 16, 2015 at 12:57 PM Ransom Briggs notifications@github.com wrote:

@dickeyxxx https://github.com/dickeyxxx do you have a recommendation for what can replace launchy in node? I was thinking maybe this, but have not looked at it super deeply yet - https://www.npmjs.com/package/open

— Reply to this email directly or view it on GitHub https://github.com/heroku/heroku/issues/1819#issuecomment-157168196.

ransombriggs commented 8 years ago

That does look better, thanks.