search

heroku / legacy-cli

Heroku CLI
https://cli.heroku.com
MIT License
1.37k stars 380 forks source link

labs:enable, labs:disable only filter on name #1921

Open mikehale opened 8 years ago

mikehale commented 8 years ago

Currently the list of Features must be unique since the CLI just looks for the first thing by name: https://github.com/heroku/heroku/blob/master/lib/heroku/command/labs.rb#L113

In order to support a future where we can have say a user feature named foo and an app feature named foo, the CLI will need to look for features by name and kind.

ransombriggs commented 8 years ago

my thought was that we would keep it backwards compatible and rather than falling back on 404, we would query both, detect duplicates, and force a flag to pick between the two

jdx commented 8 years ago

Ugh why you gotta make my life hard @mikehale :)

jdx commented 8 years ago

Btw that is not the code, this is the code https://github.com/heroku/heroku-apps/tree/master/commands/labs

mikehale commented 8 years ago

@dickeyxxx so actually I didn't realize that this feature is now handled by the node code in heroku-apps. @ransombriggs pointed me to plugins:commands, as I was confused by a simple grep of ~/.heroku.

Also this is not an urgent thing, but something that would be nice to support in the future.

jdx commented 8 years ago

there is also heroku which

jdx commented 8 years ago

@mikehale this somewhat involves this issue: https://github.com/heroku/cli/issues/259.

Essentially I plan to get rid of this command and replace it with apps:features/labs and user:features/labs