search

heroku / legacy-cli

Heroku CLI
https://cli.heroku.com
MIT License
1.37k stars 380 forks source link

normalize drains:add messaging / bogus urls? #588

Open mmcgrana opened 11 years ago

mmcgrana commented 11 years ago

How about changing:

$ heroku drains:add syslog://mydrain.com:514 -a www
Successfully added drain syslog://mydrain.com:514

to:

$ heroku drains:add syslog://mydrain.com:514 -a www
Adding drain syslog://mydrain.com:514 to www... done

Also, I'm not sure what is going on here:

$ heroku drains:add blablabla -a www
Successfully added drain syslog://blablabla:514

is the client coercing this to the bogus URL or is that happening in the API?

mmcgrana commented 11 years ago

Also should update the text here: https://devcenter.heroku.com/articles/logging#syslog-drains.

It doesn't reflect either the current or desired behavior. I can handle that if you'd like.

wuputah commented 11 years ago

I, for one, would like that.