search

heroku / legacy-cli

Heroku CLI
https://cli.heroku.com
MIT License
1.37k stars 380 forks source link

Debian package edits user dotfiles #603

Open tpope opened 11 years ago

tpope commented 11 years ago

I took a look at https://toolbelt.heroku.com/install-ubuntu.sh before I ran it, so imagine my surprise when I got through running it and my .zlogin had been molested. I'll skip the rant and get right to the obvious question: why not a /usr/bin/heroku symlink? This is what Google Chrome does, for example.

ddollar commented 11 years ago

Unfortunately many users use tools such as rvm and rbenv which inject themselves at the beginning of the PATH. In order to handle cases where the user has both the gem and the Toolbelt installed, the profile injection method was added. I agree that it's not ideal but I feel that the usability from this approach outweighs the downsides.

I'd be opening to hearing any alternatives that let us deal with this in a better way.

tpope commented 11 years ago

At the very least, could you add the symlink anyways, so that at least I don't have to leave that crap in there? My dotfiles are plenty crufty as is.

ddollar commented 11 years ago

I hear you :( Perhaps I can add the symlink back in and some which checking to determine if this is really necessary.

tpope commented 11 years ago

Another idea (which you've almost certainly given more thought to than I have) is to make the gem call the toolkit if it's available, and things should slowly sort themselves out.

On Mon, Oct 15, 2012 at 6:04 PM, David Dollar notifications@github.comwrote:

I hear you :( Perhaps I can add the symlink back in and some whichchecking to determine if this is really necessary.

— Reply to this email directly or view it on GitHubhttps://github.com/heroku/heroku/issues/603#issuecomment-9463594.

swrobel commented 11 years ago

I guess I have the opposite problem, which is that running install_ubuntu on debian didn't seem to end up in my path, so I get the following:

% heroku
zsh: command not found: heroku
tpope commented 11 years ago

Oh, you could try moving the dot file molesting stuff out into https://toolbelt.heroku.com/install-ubuntu.sh so that at least it's in plain sight, and doesn't run on every upgrade.

@swrobel try restarting your shell, and add /usr/local/heroku/bin to PATH if that doesn't work.

jdx commented 9 years ago

I believe this stuff is all gone now

jdx commented 9 years ago

oops, no it isn't. Once more of the v4 CLI stuff is out I'll be sure to resolve it though: https://github.com/heroku/heroku/blob/master/resources/deb/heroku/postinst

trimble commented 7 years ago

Did a87da812 remove the last bit of this maybe? Can this maybe be closed (again)?