search

heroku / libcnb.rs

A framework for writing Cloud Native Buildpacks in Rust
BSD 3-Clause "New" or "Revised" License
36 stars 6 forks source link

libherokubuildpack: Pack output eats `log` colors #555

Open schneems opened 1 year ago

schneems commented 1 year ago

Running this command:

$ pack build yolo --builder schneems-22 --path /tmp/rails61 --verbose

We should see header colors, but they're eaten by pack. Screenshot:

Screenshot 2023-01-31 at 3 23 10 PM

Notice that the color of [builder] right next to [Installing Ruby] is different. I think what's happening is the color code is somehow being sent before [builder] and it sets it's own color, and then clears it. We get no color because of the clear.

I'm not sure if this is something we can fix here or need to go upstream with a bug report.

edmorley commented 1 year ago

This is something that should be fixed/improved (either here or upstream), but as a workaround in the meantime, update to latest pack CLI, since it trusts the heroku/builder:22 image by default. (The reason you are seeing the [builder] prefix is since the builder is being treated as untrusted.)

edmorley commented 7 months ago

Note: The log module will be removed in the future, since it's been superseded by the build_output module, which handles the case in the OP correctly.