search

heroku / libcnb.rs

A framework for writing Cloud Native Buildpacks in Rust
BSD 3-Clause "New" or "Revised" License
34 stars 6 forks source link

Example Ruby buildpack uses `unwrap()` in non-test code #746

Closed edmorley closed 8 months ago

edmorley commented 9 months ago

We should not be using .unwrap() outside of tests.

These were found by the unwrap_used lint (which is about to be enabled across the whole repo).

https://github.com/heroku/libcnb.rs/blob/335b3514ade67db6e96df59d12e2a226325a42e2/examples/ruby-sample/src/layers/bundler.rs#L55-L57 https://github.com/heroku/libcnb.rs/blob/335b3514ade67db6e96df59d12e2a226325a42e2/examples/ruby-sample/src/layers/bundler.rs#L96 https://github.com/heroku/libcnb.rs/blob/335b3514ade67db6e96df59d12e2a226325a42e2/examples/ruby-sample/src/layers/bundler.rs#L108

edmorley commented 8 months ago

Wontfix since the Ruby example has been removed in #757.