search

heroku / libcnb.rs

A framework for writing Cloud Native Buildpacks in Rust
BSD 3-Clause "New" or "Revised" License
34 stars 6 forks source link

Fix CI failures on `main` #757

Closed edmorley closed 8 months ago

edmorley commented 8 months ago

Fixes the following CI failures on main:

  1. Lint failures on the newly released Rust 1.75 (see #756) (plus pre-emptively fixes another for Rust 1.76 beta).
  2. Integration test failures due to the Ruby example having picked up newer bundler, which is not compatible with the Ruby 2.7 it uses (see #755).

I've opted to delete the Ruby example entirely, since:

  1. This is currently blocking libcnb.rs PRs/development.
  2. It has multiple issues that really require a complete rewrite:
  3. IMO including a full language CNB example in this repo is not something we should do, since it's both never going to fully support the language in a best practice way, and also will be too complicated to demonstrate libcnb concepts in the simplified way that we should be using in an example. Instead, we should stick to simple examples of concepts (in the spirit of the basic and execd examples, but add more of them), and then separately link out to our real-world CNB repos for users who want to do further reading.

As an added bonus, the removal will speed up CI a fair amount, since the Ruby integration test was very slow (due to it bundler plus the test using a different builder image, so another docker pull).

Fixes #756. Fixes #755. Closes #398. Closes #479. Closes #746. GUS-W-14739082. GUS-W-14739086.